I noticed some unnecessary horizontal rules being rendered at the bottom of twts in the conversation view lately with yarnd’s new design change. They can be seen at least when not being logged in. Not sure if it is the same experience with an active user session. I reckon there will be fork buttons then, so in that case they would be fine, indeed.
In fact, these lines are implemented as border-top
CSS properties of twt-nav
-classed <nav>
containers. But the <nav>
s are empty, so I would expect them not being there in the first place. Empty navigation doesn’t make much sense to me.
In any case, keep up the good work! :-)
@lyse@lyse.isobeef.org @darch@neotxt.dk Can you look at this? 🤗
@prologic@twtxt.net and @lyse@lyse.isobeef.org. Those line are already removed in the latest PR😉
@darch@neotxt.dk Yup 👌 Which I updated to 👌
@prologic@twtxt.net @darch@twtxt.net It looks like the horizontal rules are completely gone, though. I thought they looked nice…
@mckinley@twtxt.net They should still work if you actually use one?
Like this? ☝️
@mckinley@twtxt.net We probably went a bit too far? I think @lyse@lyse.isobeef.org’s point was not to have a horizontal rule when it doesn’t seem appropriate?
@mckinley@twtxt.net yes I saw no need for them and it was the easiest way to fix it.
In Danish there are an expression called “narrestreger” which literally means “fools strokes”. I have learned from my sister, who is a visual designer, that you should just avoid using “narrestreger” since it only needed if your design is bad to begin with. You should rater use more blank-space, typography or colors to indicate division instead of lines.
@darch@neotxt.dk Makes sense 👌
@prologic@twtxt.net Markdown horizontal rules never worked on the Web client, as far as I know.
@darch@twtxt.net, I think that specific line had a use as a visual separator between the non-interactive text and the interactive buttons, but it’s not a hill I’m willing to die on.
@mckinley@twtxt.net we could make the Reply, Fork etc. look more like buttons, but right now it’s not on the top of my list either.