@darch@neotxt.dk Hmm this needs some minor adjustments I guess?
@prologic@twtxt.net @darch@neotxt.dk I’m also seeing the right side cropped when you have logout (so it should be the server’s default theme):
@eaplmx@twtxt.net Can someone fix this? 😅
@eaplmx@twtxt.net @prologic@twtxt.net what browser are you on? Because i don’t see the chopped-off issue in firefox…
@darch@neotxt.dk Chromium
@prologic@twtxt.net So I did something else with the Setting page: I added tabs, which mean that I got some new issues with <form action="/settings" ... >
since it now split into three.
I got it working now by using id=updateSettings
in an empty form at the top, and then adding form=“updateSettings” to all the now orphaned inputs etc., but now the existing settings are not loaded into the form elements, as you can see on the radio buttons in the screenshots.
Anyhow have a go at in the new settings_with_tabs branch :)
@darch@neotxt.dk Hmmm
@prologic@twtxt.net one nice way to fix this would be to split up action="/settings"
into 3 endpoints, so we chould have 3 normal forms instead of all the orphans
ha! I think i “accidentally” fixed it, by adding id
to all the labels, which was missing them and was not clickable.
Hmm for some reason the Custom Secondary Colors is filled in with the content from the tagline-fields…
@darch@neotxt.dk Edge 106.0.1370.52
In Firefox (Win) 105.0.3 it’s looking OK
@eaplmx@twtxt.net So much for Web Standards eh 😆🤣🤦♂️
@prologic@twtxt.net Hehe, I’m temporarily using Edge as the Windows’ Safari, while I finish my transition to Firefox, so what can I say? 😅
BTW, it’s also happening with Iridium 2022.04 so I think the problem could happen with all the Chromium-based browsers
@prologic@twtxt.net I didn’t find a better way allow the form to work across the tabs, than what I made yesterday, so I just made some small CSS fixes and cleaned up the code a bit.
The issue with the autofill in seem to be related to my Firefox settings.
Can someone else take the settings_with_tabs branch for a spin on a dev-pod, to make sure it doesn’t accidentally delete the users settings or something, before I make a PR?
@darch@neotxt.dk I can do some testing today…
@darch@neotxt.dk I tested every form on every tab and they all work! 🥳 Well done 👏 Also looks very nice too! I love it! I think we can borrow this “Tab” UI you’ve got for Lists? 🤔 (thinking a similar thing for Mobile App too)
@prologic@twtxt.net thanks😊 yes that was also my idea that we could reuse the design other places. If you check under Poderator on that branch you shoulde see it effects there too.
We still need to work out the mobil view for the tabs-desig - I would like it to show the tab-labels all stacked on the top so it’s easier to pick the one you want to go to instead of scrolling and then clicking the next one to show.
@prologic@twtxt.net also was the radio buttons or check boxes emnty when you first loaded the new branch?
@darch@neotxt.dk Nope they were not (I don’ think?) At least checkboxes weren’t.
@prologic@twtxt.net Great, then I just need to fix the mobile view
@darch@neotxt.dk Ok 👌 Let me know when good to merge 👍